Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking!: refactor options #21

Merged
merged 1 commit into from
Apr 26, 2022
Merged

breaking!: refactor options #21

merged 1 commit into from
Apr 26, 2022

Conversation

mvllow
Copy link
Owner

@mvllow mvllow commented Apr 26, 2022

Breaking

  • Removed focus_only option. This is now the default behaviour of modes. To fully take advantage of this, allow modes to manage all available options (see below).

Features

  • Added set_cursorline and set_number to compliment the existing set_cursor. When using these options, modes will be disabled for inactive windows or ignored filetypes.
  • Added ignore_filetypes. Modes will be disabled for any ignored filetype. Please PR any commonly ignored filetypes.

Closes #13
Closes #16
Ref #17

- removed `focus_only` as this is now handled automatically
- added `set_cursorline`
  - automatically handle vim.opt.cursorline and highlights
- added `set_number` and changed number behaviour
  - foreground is no longer modified
  - background matches cursorline
- added `ignore_filetypes`
@mvllow mvllow merged commit b6c910d into main Apr 26, 2022
@mvllow mvllow deleted the refactor-options branch April 26, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default normal mode CursorLine highlight not used RFC: Handling line number highlights
1 participant