Skip to content

[FEATURE] Update Naming Conventions #22

Closed

Description

@itsxallwater

Is your feature request related to a problem? Please describe.
The project still references MVON and ONgroup. Need to update to change MVON references to MV Basic and ONgroup references to MV Extensions.

Describe the solution you'd like
Make the name changes, specifically focusing on extension configuration names and publisher info but elsewhere as acceptable/necessary.

An example where not necessary, the client\Syntaxes\MvLanguage.json file referencing "MVON# Basic" as a Language type.

An example where necessary, the client\src\extension.ts file referencing "mvon" as the configuration namespacece

Activity

  1. itsxallwater commented on Jul 5, 2019

    @itsxallwater
    MemberAuthor

    Note that @CharlesBarouch is in progress on this so assigning to him!

  2. dthiot commented on Jul 8, 2019

    @dthiot
    Contributor

    I took much of the reference to ONgroup and MVON# out of the documentation. However, I wasn't exactly sure how to replace it and chose MVextensions.

  3. added a commit that references this issue on Jul 30, 2019
  4. itsxallwater commented on Aug 1, 2019

    @itsxallwater
    MemberAuthor

    @CharlesBarouch thanks for the commit, I've not yet had a chance to look but will try to do so and get you notes. @GrantHart if you wanted to peek here's just a tag to give you a heads up that Chuck got some name changes committed for the team to review w/ commit 15998cc.

  5. itsxallwater commented on Sep 6, 2019

    @itsxallwater
    MemberAuthor

    Name changes have been pushed to master. Thanks @CharlesBarouch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions