Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing value on signal start after until #222

Merged
merged 6 commits into from
Jan 7, 2021
Merged

Fix missing value on signal start after until #222

merged 6 commits into from
Jan 7, 2021

Conversation

Gaudeval
Copy link
Contributor

@Gaudeval Gaudeval commented Jan 6, 2021

Fix #221

Changes include:

  • Add function to interpolate all tags in a signal at a given timestamp
  • Force valuation of all tags on signal start
  • Small regression test

@Gaudeval
Copy link
Contributor Author

Gaudeval commented Jan 6, 2021

I do apologise as I did not realise I was not on a separate branch while working on a fix for #217.

This now includes changes to force the evaluation of the timed operators at points of interest, and assorted tests.

@mvcisback
Copy link
Owner

Thanks for the quick PR :)

Quick skim looks good. I'll try to take a deeper look sometime tomorrow!

mvcisback
mvcisback approved these changes Jan 7, 2021
View reviewed changes
Copy link
Owner

@mvcisback mvcisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvcisback mvcisback merged commit 2aaa340 into mvcisback:master Jan 7, 2021
@Gaudeval Gaudeval deleted the fix/221-until-slicing branch January 29, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvcisback mvcisback mvcisback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty or incorrect Until signal if argument start is anterior to output start
2 participants
@Gaudeval @mvcisback