Skip to content

[ADD] support context manager on Client #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvantellingen merged 2 commits into from
Nov 3, 2022
Merged

[ADD] support context manager on Client #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d229e8
[ADD] support context manager on Client
Nov 14, 2020
a008ac6
[ADD] test context manager client
Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/zeep/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,12 @@ def _get_service(self, name: typing.Optional[str]) -> str:
service = next(iter(self.wsdl.services.values()), None)
return service

def __enter__(self):
return self

def __exit__(self, exc_type=None, exc_value=None, traceback=None):
self.transport.close()


class AsyncClient(Client):
_default_transport = AsyncTransport
Expand Down
5 changes: 5 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ def test_service_proxy_non_existing():
assert client_obj.service.NonExisting


def test_context_manager():
with client.Client("tests/wsdl_files/soap.wsdl") as client:
assert client


def test_service_proxy_dir_operations():
client_obj = client.Client("tests/wsdl_files/soap.wsdl")
operations = [op for op in dir(client_obj.service) if not op.startswith("_")]
Expand Down