- 
                Notifications
    You must be signed in to change notification settings 
- Fork 234
scripts: switch to Ubuntu Jammy Jellyfish (22.04) by default #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than inverting predicate on distro
        
          
                scripts/chroot_build.sh
              
                Outdated
          
        
      | grub2-common \ | ||
| locales | ||
|  | ||
| if [ "$TARGET_UBUNTU_VERSION" != "jammy" ]; then | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concern: I think this would be better if we invert the predicate.  It's unlikely that future version of Ubuntu would re-introduce lupin-casper so better to only install it on specific platforms.  Less future maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your Feedback! I'll adjust this later today :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Take Care about bionic and focal? Or also cosmic, disco, eoan and groovy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good question. @mvallim what versions of Ubuntu do we officially support? Just LTS or every release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If he doesn't respond then probably best to just check for everything from bionic, which I believe is the earliest version supported by this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive force pushed already checking for focal and bionic https://github.com/mvallim/live-custom-ubuntu-from-scratch/compare/72a556f94db77bd39578c82f172fae5652409287..25993b69abd82285d11d406fd646595d3f605016
Maybe add more versions later if needed?  Bionic, focal and Jammy are those handled via GitHub actions.
The versions between also reached the end of official Support and i would need to know where the package Starts to be unavailable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not Sure If interesting for your:
master...andi34:live-custom-ubuntu-from-scratch:docker
Ive started to build via Docker, works fine so far. Based on pi-gen's Docker build process. Pi-gen ist released under the BSD 3-Clause "New" or "Revised" License,  Not Sure If thats a Problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lupin-casper is not available on Ubuntu Jammy Jellyfish, only install on other Ubuntu versions.
| I just tested this PR and it works for me, on Ubuntu 22.04.1 LTS, and it works for me. Thanks ! | 
lupin-casper is not available on Ubuntu Jammy Jellyfish, only install on other Ubuntu versions.
Fixes #45