Skip to content

Conversation

@andi34
Copy link
Contributor

@andi34 andi34 commented Aug 8, 2022

lupin-casper is not available on Ubuntu Jammy Jellyfish, only install on other Ubuntu versions.

Fixes #45

Copy link
Collaborator

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than inverting predicate on distro

grub2-common \
locales

if [ "$TARGET_UBUNTU_VERSION" != "jammy" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concern: I think this would be better if we invert the predicate. It's unlikely that future version of Ubuntu would re-introduce lupin-casper so better to only install it on specific platforms. Less future maintenance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Feedback! I'll adjust this later today :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Take Care about bionic and focal? Or also cosmic, disco, eoan and groovy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good question. @mvallim what versions of Ubuntu do we officially support? Just LTS or every release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If he doesn't respond then probably best to just check for everything from bionic, which I believe is the earliest version supported by this project.

Copy link
Contributor Author

@andi34 andi34 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive force pushed already checking for focal and bionic https://github.com/mvallim/live-custom-ubuntu-from-scratch/compare/72a556f94db77bd39578c82f172fae5652409287..25993b69abd82285d11d406fd646595d3f605016

Maybe add more versions later if needed? Bionic, focal and Jammy are those handled via GitHub actions.
The versions between also reached the end of official Support and i would need to know where the package Starts to be unavailable.

Copy link
Contributor Author

@andi34 andi34 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Sure If interesting for your:

master...andi34:live-custom-ubuntu-from-scratch:docker

Ive started to build via Docker, works fine so far. Based on pi-gen's Docker build process. Pi-gen ist released under the BSD 3-Clause "New" or "Revised" License, Not Sure If thats a Problem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me @andi34 . I'll give @mvallim some time to see this to see if he has anything to add.

IRT docker branch, nice! I think that will help a lot of users that may get stuck w/ local env issues. Very cool 👍

lupin-casper is not available on Ubuntu Jammy Jellyfish, only install
on other Ubuntu versions.
@rgrunbla
Copy link

I just tested this PR and it works for me, on Ubuntu 22.04.1 LTS, and it works for me. Thanks !

@mvallim mvallim merged commit 57a2f8a into mvallim:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packages seem unavailable on Jammy

4 participants