Skip to content

NFC: Cleaner non standard input handler invocation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023
Merged

NFC: Cleaner non standard input handler invocation #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions Sources/MuxUploadSDK/PublicAPI/MuxUpload.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,17 +486,11 @@ public final class MuxUpload : Hashable, Equatable {

switch inspectionResult {
case .inspectionFailure:
// TODO: Request upload confirmation
// before proceeding

guard let nonStandardInputHandler = self.nonStandardInputHandler else {
self.startNetworkTransport(
videoFile: videoFile
)
return
}

let shouldCancelUpload = nonStandardInputHandler()
// Request upload confirmation
// before proceeding. If handler unset,
// by default do not cancel upload if
// input standardization fails
let shouldCancelUpload = self.nonStandardInputHandler?() ?? false

if !shouldCancelUpload {
self.startNetworkTransport(
Expand Down Expand Up @@ -548,14 +542,11 @@ public final class MuxUpload : Hashable, Equatable {
videoFile: outputURL
)
} else {
guard let nonStandardInputHandler = self.nonStandardInputHandler else {
self.startNetworkTransport(
videoFile: videoFile
)
return
}

let shouldCancelUpload = nonStandardInputHandler()
// Request upload confirmation
// before proceeding. If handler unset,
// by default do not cancel upload if
// input standardization fails
let shouldCancelUpload = self.nonStandardInputHandler?() ?? false

if !shouldCancelUpload {
self.startNetworkTransport(
Expand Down