feat: support setting non-primitive values as props instead of attr #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this because the fix ended up being serializing the prop value. This was and edge case because in most cases when the property value is a complex value it doesn't have a reflecting attribute and the corresponding attribute wouldn't be observed. In this case ce-la-react correctly sets it as a property. ce-la-react/src/ce-la-react.ts Line 219 in 35e616f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the createComponent logic to ensure that when a web component attribute is a non-primitive (e.g. object, array), it is assigned directly as a property on the custom element.
This change addresses muxinc/media-chrome#1120, where the attribute rates in react its expected to be an array and was ignored by the current implementation.