all: backport changes for v0.16.6 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Howard <jacob@mutagen.io>
This commit adds neutralization (escaping) of control characters in terminal output for values that aren't locally controlled. This output (if unsanitized) coud cause terminal corruption. In theory, it could also be used as an attack vector for intentionally causing terminal corruption when synchronizing with an untrusted (and malicious) remote. On very old terminal emulators, it can theoretically be used as an attack vector for code execution (see, for example, CVE-2003-0069), though this type of vulnerability has been patched for over 20 years. We still treat the daemon as a trusted entity (since it is under user control) and don't sanitize (most) output under its control (such as locally generated error messages). We intentionally avoid sanitizing templated output because that output needs to contain raw, unmodified values. A shellSanitize function has been added to support neutralization of control characters in template output. Signed-off-by: Jacob Howard <jacob@mutagen.io>
Signed-off-by: Jacob Howard <jacob@mutagen.io>
Signed-off-by: Jacob Howard <jacob@mutagen.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do and why is it needed?
This PR backports updates and fixes for v0.16.6. More information will be available in the associated release notes.