Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the frontend build system for the PostgreSQL Manager from using a separate workaround module to using go:generate directives with embedded filesystems. This simplifies the build process by eliminating the need for a dummy module in build/wasm/pgmanager.
Key Changes:
- Replaced external module dependency with inline go:generate directive and embed.FS for frontend assets
- Simplified the Makefile build targets by removing the workaround for embedding frontend files
- Updated .gitignore to reflect the new frontend build location
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/manager/httphandler/frontend_included.go | New file that uses go:generate and embed.FS to handle frontend assets inline |
| pkg/manager/httphandler/frontend.go | Removed - replaced by frontend_included.go with the new approach |
| go.mod | Removed workaround module dependency and replace directive, plus transitive grpc dependencies |
| README.md | Updated description to mention optional frontend (minor spelling issue with "prometheus") |
| Makefile | Simplified pgmanager and tidy targets to use go:generate instead of manual module creation |
| .gitignore | Added ignore pattern for the generated frontend directory in the new location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.