Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Vulkan runtime libraries to the Docker image and improves the documentation for verifying Vulkan functionality within containers. The changes ensure that users can properly test GPU acceleration capabilities when running the go-media container.
- Added Vulkan runtime libraries (
libvulkan1andvulkan-tools) to the Docker runtime image - Updated troubleshooting commands to use proper
--entrypointsyntax for runningvulkaninfoin containers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| etc/docker/Dockerfile | Added libvulkan1 and vulkan-tools packages to the runtime stage, enabling Vulkan functionality in the final container image |
| docs/docker-gpu.md | Updated troubleshooting commands to use --entrypoint vulkaninfo with --summary as a separate argument, improving command clarity and correctness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Vulkan runtime libraries to the Docker image and improves the documentation for verifying Vulkan functionality within containers. The changes ensure that users can properly test GPU acceleration capabilities when running the go-media container.
A further PR is needed to add hardware decoding support.