Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy: Add music_assistant.common #1428

Merged
merged 12 commits into from
Jul 2, 2024
Merged

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Jun 30, 2024

I've added some comments where i'm a bit uncertain on this one.

@Jc2k Jc2k enabled auto-merge (squash) June 30, 2024 08:48
music_assistant/client/music.py Outdated Show resolved Hide resolved
music_assistant/common/helpers/json.py Show resolved Hide resolved
music_assistant/common/helpers/util.py Show resolved Hide resolved
music_assistant/common/models/config_entries.py Outdated Show resolved Hide resolved
music_assistant/common/models/config_entries.py Outdated Show resolved Hide resolved
music_assistant/common/models/enums.py Show resolved Hide resolved
music_assistant/common/models/media_items.py Show resolved Hide resolved
music_assistant/common/models/media_items.py Show resolved Hide resolved
music_assistant/common/models/media_items.py Show resolved Hide resolved
music_assistant/common/models/media_items.py Show resolved Hide resolved
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive, nice work!

@Jc2k Jc2k merged commit c2884f9 into music-assistant:main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants