Fix: don't throw warning for unsubscribe results#195
Fix: don't throw warning for unsubscribe results#195marcelveldt merged 3 commits intomusic-assistant:mainfrom
Conversation
it always created a warning: Received result for unknown message with ID: x
|
Continuation of the other reply. Maybe we should not care and just log this to verbose. In nay case its not worth it to await the unsub reply unless I'm missing some usecase here. Are you perhaps interested in doing sub+unsub during runtime ? Maybe all this takes is a separation of the subscribe and unsubscribe, make them 2 individual functions and leave it up the caller to handle. |
This reverts commit 40160f9.
|
Yes, sub+unsub during runtime. :) Hmmm, and how will the caller identify the subscription if it is a separete method? Currently the The only thing that bothered me, was the warning, if the warning is only a debug/verbose message, I'm fine with it. |
|
I was thinking of giving back the subscription ID so you can store that and decide for yourself if you want to unsubscribe. |
Without waiting for the reply, it always created a warning: Received result for unknown message with ID: x