adding journald and enabling syslog logging #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenfo
requested changes
Mar 17, 2021
| def __init__(self, host, port, facility, logdevice, logsocket): | ||
| logger = logging.getLogger() | ||
| self.logger = logging.getLogger("conpot") | ||
| handler = logging.StreamHandler() |
Contributor
There was a problem hiding this comment.
This way we're silently swallowing configuration errors (typos mostly). It's also a bit odd to have a "SyslogLogger" print to the console. I'd rather raise an error below.
Alternatively we could make this behavior explicit, like if str(logsocket).lower() == "stderr":, because it should actually be useful to have events printed to the console. At that point we may as well rename "socket" to "mode".
But then we should be able to use /dev/stderr to the same effect - but I haven't tested it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.