Use BagdeKind::VIP in Privmsg::is_vip instead of BagdeKind::Broadcaster
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Privmsg::is_vipused to check forBadgeKind::Broadcaster, butis_vipdescribes to whether the message is sent by Twitch Channel VIP. It closes #232.Type of Change
This change fixes the prior incorrect behaviour of
Privmsg::is_vipby now checking forBadgeKind::VIPinstead. The behaviour change is a fix and therefore stable.How Has This Been Tested?
Before, messages by VIPs of a Twitch Channel would cause
msg.is_vip()to evaluate tofalse, while I expectedtrue. Once the code change was applied, the expression evaluated totruefor VIPs andfalsefor users without the VIP badge.