Skip to content

Fix gap between toasts - #234

Open
embarc-gabriel wants to merge 1 commit into
musescore:mainfrom
embarc-gabriel:11723-fix-gap-between-toast
Open

Fix gap between toasts#234
embarc-gabriel wants to merge 1 commit into
musescore:mainfrom
embarc-gabriel:11723-fix-gap-between-toast

Conversation

@embarc-gabriel

Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#11723

We should not consider shadow height on item height calculation.
The current gaps is spacing + shadow height.

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ed4ad4d4-8865-4669-ad89-ae9bd862b303

📥 Commits

Reviewing files that changed from the base of the PR and between 07c98aa and 690d629.

📒 Files selected for processing (2)
  • framework/toast/qml/Muse/Toast/ToastItem.qml
  • framework/toast/qml/Muse/Toast/ToastProvider.qml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Toast items no longer expose shadowMargin. Their implicit height uses content height and vertical margins. The background no longer applies shadow-margin anchors. The toast list disables clipping.

Merge Risk: ⚪ Minimal · up to 690d6

This change adjusts toast item sizing so shadow height does not add extra gaps between toasts; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: correcting excessive spacing between toasts.
Description check ✅ Passed The description includes the issue link, motivation, completed checklist, build configuration, and an appropriate explanation of the fix.
Linked Issues check ✅ Passed The changes remove shadow height from toast sizing and address the excessive gap described in issue #11723.
Out of Scope Changes check ✅ Passed Both modified files support the toast spacing fix, and no unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gap between toast notifications should only be 12px

2 participants