[macOS] Allow opening files from Finder, dock icon menu and more #9411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/project/internal/platform/macos/projectopeneventhandler.cpp
Outdated
Show resolved
Hide resolved
By handling QFileOpenEvents.
cbjeukendrup
force-pushed
the
file_open_event
branch
from
ea8156a to
14b74d6
Compare
RomanPudashkin
approved these changes
Oct 11, 2021
|
Tested #8236 on latest master build on Mac11.6 - DONE Now works on Mac. Thanks for fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8236
Before, in MU4 it was only possible to open files from within the app (for example, from the home tab, or the open recent menu).
Now, the app also reacts to File Open events from macOS, so now you can open files from Finder, from the context menu of MuseScore's Dock icon (which makes the work done in PR #8299 a lot more useful), and more (just like in MU3).
(If you have MU3 installed too, macOS will likely prefer using MU3, so you would have to choose "Open with > MU4".)
On Windows, it already works (sort of) due to the multi-instances system.
I also performed a very small cleanup in some CMakeLists.txt files.