Skip to content

[DAISY] Accessibility: Improve speech for various elements #8877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DAISY] Accessibility: Improve speech for various elements #8877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
176a952
Fix #307442 Accessibility: Speech for tuplets with more than 9 notes
shoogle Aug 19, 2021
2943b26
Fix #312625 Accessibility: Speak notehead group type
shoogle Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/engraving/libmscore/chordrest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,8 @@ QString ChordRest::durationUserName() const
tupletType = QObject::tr("Nonuplet");
break;
default:
tupletType = QObject::tr("Custom tuplet");
//: %1 is tuplet ratio numerator (i.e. the number of notes in the tuplet)
tupletType = QObject::tr("%1 note tuplet").arg(tuplet()->ratio().numerator());
}
}
QString dotString = "";
Expand Down
4 changes: 3 additions & 1 deletion src/engraving/libmscore/note.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3279,7 +3279,9 @@ QString Note::screenReaderInfo() const
} else if (staff()->isTabStaff(tick())) {
pitchName = QObject::tr("%1; String: %2; Fret: %3").arg(tpcUserName(true), QString::number(string() + 1), QString::number(fret()));
} else {
pitchName = tpcUserName(true);
pitchName = _headGroup == NoteHead::Group::HEAD_NORMAL
? tpcUserName(true)
: QObject::tr("%1 head %2").arg(subtypeName()).arg(tpcUserName(true));
}
return QString("%1 %2 %3%4").arg(noteTypeUserName(), pitchName, duration, (chord()->isGrace() ? "" : QString("; %1").arg(voice)));
}
Expand Down