Fix #321960: [MusicXML export] Tempo beating at the whole does not ex… #8793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 4, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 4, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 7, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 9, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
|
Test failure seems completely unrelated to the change in this pull request: |
|
Yes, those do happen at times and seemingly random. |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
|
I guess after re-running the vtests this one should be ready for merge? |
|
Most likely. Is there any way to achieve that (besides updating the branch, e.g. by rebasing) ? |
|
Not for mere mortals like us . |
lvinken
force-pushed
the
321960-musicxml-beat-unit-master
branch
from
c5cb07c to
b03bbff
Compare
|
rebase needed |
|
Will do |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
lvinken
force-pushed
the
321960-musicxml-beat-unit-master
branch
from
b03bbff to
2d6f109
Compare
| QString unit; | ||
| findUnit(dur.type(), unit); | ||
| xml.tag("beat-unit", unit); | ||
| xml.tag("beat-unit", dur.name()); |
There was a problem hiding this comment.
This method doesn't exist (anymore?)
There was a problem hiding this comment.
Apparently to be replaced by TConv::toXml().
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp.
lvinken
force-pushed
the
321960-musicxml-beat-unit-master
branch
from
2d6f109 to
52f8a34
Compare
RomanPudashkin
approved these changes
May 27, 2022
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…port in .musicxml format Caused by superfluous and incomplete findUnit() function in exportxml.cpp. Backport of musescore#8793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port in .musicxml format
Resolves: https://musescore.org/en/node/321960
Issue leads to invalid and incomplete MusicXML export. Trivial bug, caused by superfluous and incomplete findUnit() function in exportxml.cpp. Solution supports all tempo text note values supported by MuseScore.