[MU3 Backend] ENG-63: Properly handle cue grace notes #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these.
oktophonie
approved these changes
Jul 12, 2021
vpereverzev
approved these changes
Jul 14, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 15, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning
| @@ -4842,7 +4871,7 @@ Note* MusicXMLParserPass2::note(const QString& partId, | |||
| else if (_e.name() == "stem") | |||
| stem(stemDir, noStem); | |||
| else if (_e.name() == "type") { | |||
| small = _e.attributes().value("size") == "cue"; | |||
| small = _e.attributes().value("size") == "cue" | _e.attributes().value("size") == "grace-cue"; | |||
There was a problem hiding this comment.
This causes a compiler warning due to missing parentheses. Also I guess it should be || rather than |?
There was a problem hiding this comment.
#8554 (for posterity)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 19, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Previously, our importer and exporter didn't account for notes that were both grace notes and cue notes (therefore extra-small in size). This commit amends that. Additionally, since Dolet also seems to fail in this area, this commit adds a function to coerce the `small` and `play` attributes of a grace chord to match that of its main chord. Finally, it adds support for the "grace-cue" size to the exporter and importer. In the importer, this is treated the same as the "cue" size, as exporters tend to misinterpret the distinction between these. Duplicate of musescore#8581, plus fixing a compiler warning, see musescore#8554
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
This part an earlier port of musescore#8581 somehow got lost
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
This part of an earlier port of musescore#8581 somehow got lost
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
This part of an earlier port of musescore#8581 somehow got lost
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 17, 2024
This part of an earlier port of musescore#8581 somehow got lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-63: Grace notes within 'small' passages are not being reduced
Previously, our importer and exporter didn't account for notes that
were both grace notes and cue notes (therefore extra-small in size).
This commit amends that. Additionally, since Dolet also seems to fail
in this area, this commit adds a function to coerce the
smallandplayattributes of a grace chord to match that of its main chord.Finally, it adds support for the "grace-cue" size to the exporter and
importer. In the importer, this is treated the same as the "cue" size, as
exporters tend to misinterpret the distinction between these.