[MU3] Fix #303422: Importing colored lyrics from MusicXML #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Jojo-Schmitz wants to merge 2 commits into musescore:3.x from Jojo-Schmitz:musicxml-lyrics-color-3.x

Contributor

Jojo-Schmitz commented Apr 30, 2021 •

edited

Loading

Resolves: https://musescore.org/en/node/303422

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

This is for 3.x what #8033 is for master, as on master MusicXML import can't get tested currently...

Image of importing the test file, mtest/musicxml/io/testLyricColor.xml:

This was referenced Apr 30, 2021

[MU4] Fix #303422: Importing colored lyrics from MusicXML #8033

Merged

[MU3] fix #303422: lyrics color is preserved when importing mxml + small bugfix and cleanup for isEven #6021

Closed

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz force-pushed the musicxml-lyrics-color-3.x branch from be3fb95 to 3a1df03 Compare

April 30, 2021 13:22

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

d53ff8f

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

15c5d04

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added 2 commits

May 20, 2021 13:13


           Fix #303422: Importing colored lyrics from MusicXML

ea90cc6

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together


          While at it ... make use of the now working isEven()

4f830c5

Jojo-Schmitz force-pushed the musicxml-lyrics-color-3.x branch from 3a1df03 to 4f830c5 Compare

May 20, 2021 11:14

Jojo-Schmitz mentioned this pull request

[MU3 Backend] ENG-18: Fretboard Diagrams #8116

Merged

8 tasks

vpereverzev closed this

Contributor Author

Jojo-Schmitz commented May 31, 2021

@iveshenry18 this one might be something for your 3.6.2_backend fixes too

Jojo-Schmitz deleted the musicxml-lyrics-color-3.x branch

May 31, 2021 17:35

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

c58facb

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

652854b

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

b8b62ce

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

5bd939d

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

c6b4144

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

cbfb0bd

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

01e2e35

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

0e61eb9

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

7eae111

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

10799bc

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

9fa049c

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

37dd430

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

50380d2

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

2eca7c9

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

f43ceab

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

da64ad6

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

b3fdbfe

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

cccb11a

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

ed5bd02

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

0185cd7

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

6eed68d

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

0223cfc

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

be8049f

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

8064cd6

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

098278d

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

9db2f03

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

3a5b595

Backport of musescore#8033, resp. duplicate of musescore#8034. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

d4f4a26

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034, part 1. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

f8186e2

Backport of musescore#8033, resp. duplicate of musescore#8034, part 2. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

f8e18a2

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034, part 1. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

4a62c22

Backport of musescore#8033, resp. duplicate of musescore#8034, part 2. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

e83341b

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034, part 1. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

e4909a5

Backport of musescore#8033, resp. duplicate of musescore#8034, part 2. See also musescore#6021

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


           Fix #303422: Importing colored lyrics from MusicXML

893c05c

Up to 3.5 it worked only for first line (number="1"), in 3.6 and master it stopped working all together

Backport of musescore#8033, resp. duplicate of musescore#8034, part 1. See also musescore#6021

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          While at it ... make use of the now working isEven()

b2d5090

Backport of musescore#8033, resp. duplicate of musescore#8034, part 2. See also musescore#6021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet