[MU3] Fix #319079: Shift Selecting Last Word #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Jojo-Schmitz wants to merge 2 commits into musescore:3.x from Jojo-Schmitz:shift-select-3.x

Contributor

Jojo-Schmitz commented Apr 13, 2021 •

edited

Loading

Resolves: https://musescore.org/en/node/319079

Original code only attempts to find the next ChordRest segment as the end marker for selecting a range, this fix adds the detection for the EndBarLine segment as a potential end marker, which resolves the issue.

Backport of #7793 to the 3.x branch

ht-gong added 2 commits

April 13, 2021 09:23


          Fix #319079: Shift Selecting Last Word fails

79920bd

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793


          Fix Issue with Shift Selecting Across Staffs

e87f8f9

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz changed the title ~~MU3] Fix #319079: Shift Selecting Last Word~~ [MU3] Fix #319079: Shift Selecting Last Word

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

6aba228

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

8a58968

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

15fcb69

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

368f0b0

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

f407a7d

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

5a349ef

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

vpereverzev added the archived label

Member

vpereverzev commented Apr 28, 2021

merges to 3.x are closed now

vpereverzev closed this

Jojo-Schmitz deleted the shift-select-3.x branch

April 28, 2021 11:49

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

7c577e1

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

8ae1d79

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

a59a180

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

24666f8

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

86b5814

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

fe2dd80

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

b30d98b

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

5199b88

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

51d4744

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

298f005

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

1039ef5

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

13a1c06

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

fc193d9

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

1d71f36

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

72eebe3

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

fc8d944

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

1c3964a

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

31d8855

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

63508cb

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

043c620

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

9a13541

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

cac48ff

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

6ec68ec

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

ddb6b13

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

04599fd

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

c8d8104

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

76f3689

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

2f888a6

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

faea6cc

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

9d2280f

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 2

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix #319079: Shift Selecting Last Word fails

fb72b7c

Changed condition to only check for s1. s2 might be nullptr which marks
end of score.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix Issue with Shift Selecting Across Staffs

21812d6

Assert enforces ending staffidx to be higher than starting staffidx. This code reverses the two indexes if they don't satisfy idx2 >= idx1.

Backport of musescore#7793, resp. duplicate of musescore#7947, part 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels