[MU3] Image paste crashes #7699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
image-paste-crash
branch
3 times, most recently
from
0e5ab80 to
1caa8f7
Compare
vpereverzev
reviewed
Mar 9, 2021
libmscore/textbase.cpp
Outdated
| @@ -10,6 +10,8 @@ | |||
| // the file LICENCE.GPL | |||
| //============================================================================= | |||
|
|
|||
| #include "global/log.h" | |||
There was a problem hiding this comment.
I suggest to not include it here, otherwise we can easily miss this during the port of the changes
in short, we're going to reduce external dependencies from "libmscore" in master
There was a problem hiding this comment.
OK, removed this. Reduces this PR to a port of @mattmcclinch's fix for master to 3.x
Jojo-Schmitz
force-pushed
the
image-paste-crash
branch
from
1caa8f7 to
bddd083
Compare
Jojo-Schmitz
force-pushed
the
image-paste-crash
branch
from
bddd083 to
a77aeff
Compare
Jojo-Schmitz
commented
Mar 9, 2022
| if (_selection.element()) | ||
| addRefresh(_selection.element()->abbox()); | ||
| if (target->acceptDrop(ddata)) { | ||
| ddata.dropElement = nel; |
There was a problem hiding this comment.
Darn, this line should have stayed before the if
Edit: now fixed in #9000
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 9, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 15, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 17, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 17, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 17, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Fixing a screw-up of mine from musescore#7699 (a backport of musescore#7698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: