Skip to content

[MU3] Fix #318034: Make Harmonium SND capable. #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Feb 25, 2021

Reed Organ is, and is (basically) the same instrument.

Resolves: https://musescore.org/node/318034

See discussion on Telegram too: https://t.me/musescoreeditorchat/104446

Same should go to master too, see #7607

Reed Organ is, and is the same instrument.
@vpereverzev
Copy link
Member

merged in master

@vpereverzev vpereverzev closed this Mar 4, 2021
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Mar 4, 2021

Needed on 3.x too though.
Is closing this here the penalty for me having done the port to master myself?

@vpereverzev
Copy link
Member

Of course it's not
I was aimed to merge in 3.x only those changes that we still need to port in master. But actually, there is no harm to "just" merge it in 3.x and then port only "libmscore" changes, so maybe I was in a hurry with this

@vpereverzev vpereverzev reopened this Mar 4, 2021
@Jojo-Schmitz
Copy link
Contributor Author

I thought so, but felt like being punished ;-)

@vpereverzev
Copy link
Member

I thought so, but felt like being punished ;-)

Yeah, sorry for that, I'm going to take another look on PRs that have been closed during this day. I guess we can merge them, just in case

@vpereverzev vpereverzev merged commit 4d55c83 into musescore:3.x Mar 4, 2021
@Jojo-Schmitz Jojo-Schmitz deleted the harmonium branch March 4, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants