fix #313977: avoid adding a palette element twice on double-click #7590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const index = paletteCell.modelIndex; | ||
| paletteView.selectionModel.setCurrentIndex(index, ItemSelectionModel.Current); | ||
| paletteView.paletteController.applyPaletteElement(index, mouse.modifiers); | ||
| // Empty handler to avoid onClicked being triggered twice on double-click. |
There was a problem hiding this comment.
I love issues getting fixed by removing code ;-)
|
I wonder whether this would need to get ported to master |
|
As far as I can tell the culprit code is still in master, see MuseScore/src/palette/qml/MuseScore/Palette/internal/Palette.qml Lines 543 to 547 in bb06849 |
|
See #11462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/313977
The issue doesn't happen in MuseScore 3.4.2 but happens in the 3.5 version. The possible reason is that #5474 has occasionally reverted the previous commit which had fixed this issue, 77e4347. This pull request returns the empty double-click handler back. Removing the handler entirely causes two
onClickedevents being triggered and results in identical elements being added as well, so we have to put an empty handler there to prevent this.