Skip to content

[MU3] Fixed version change when saving to file #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MU3] Fixed version change when saving to file #7414

wants to merge 1 commit into from

Conversation

Eism
Copy link
Contributor

@Eism Eism commented Feb 4, 2021

@Eism Eism marked this pull request as draft February 4, 2021 11:47
@Eism Eism changed the base branch from 3.x to 3.6 February 4, 2021 11:51
@Eism Eism changed the base branch from 3.6 to 3.x February 4, 2021 11:53
@Eism Eism force-pushed the update_score_fix branch from 3d99ca9 to 8e39cf0 Compare February 4, 2021 12:02
@Eism Eism changed the base branch from 3.x to 3.6.1 February 4, 2021 12:03
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Feb 4, 2021
Closed
53 tasks
@Eism Eism force-pushed the update_score_fix branch from 8e39cf0 to 68ff900 Compare February 4, 2021 13:26
@Jojo-Schmitz
Copy link
Contributor

I guess the failing mtests are expected and so the ref scores need to get adjusted?

@Eism Eism force-pushed the update_score_fix branch 2 times, most recently from 36fab40 to 9a429ee Compare February 4, 2021 13:38
@Eism
Copy link
Contributor Author

Eism commented Feb 4, 2021

@Jojo-Schmitz, yes, fixed

@Eism Eism marked this pull request as ready for review February 4, 2021 13:40
@Eism Eism force-pushed the update_score_fix branch from 9a429ee to 9dd6cf0 Compare February 4, 2021 13:43
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Feb 8, 2021
Closed
@Eism Eism changed the base branch from 3.6.1 to 3.6.2 February 9, 2021 15:01
@Eism Eism force-pushed the update_score_fix branch from 9dd6cf0 to 7c196ad Compare February 9, 2021 15:07
@vpereverzev
Copy link
Member

after all we've decided to keep MU2 on backend, that's why we can close this PR freely now

@vpereverzev vpereverzev closed this Mar 4, 2021
@Eism Eism deleted the update_score_fix branch January 9, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eism @Jojo-Schmitz @vpereverzev