Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3.x) fix 280260: added an option to set the default font for all text types #7127

Closed
wants to merge 1 commit into from

Conversation

SKefalidis
Copy link
Contributor

Resolves: 3.x version of #5816

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [n\a] I created the test (mtest, vtest, script test) to verify the changes I made

@SKefalidis
Copy link
Contributor Author

Added button:
image

@Tantacrul
Copy link
Contributor

Tantacrul commented Dec 21, 2020

I think it's cool we've addressed this problem. I do think we need a slightly more blunt and discoverable option. I also dislike putting this here. I have a few suggestions for an alteration or two. Really glad the functionality has been built though!

@shoogle
Copy link
Contributor

shoogle commented Dec 23, 2020

@Tantacrul, how does the above compare to my suggestion here? Basically there would only be a single font dropdown and no button. The dropdown would initially show "Edwin", and if it was subsequently changed to "Noto Sans Arabic UI" then all text styles that were previously using Edwin would be updated to the new font.

@vpereverzev
Copy link
Member

It's a feature-freeze stage for 3.6 now, so I'll close this PR, because it's a kind of feature that should be implemented carefully.
I suggest to focus on a version for master and consider @Tantacrul UX suggestions.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 6, 2021

I'll try to merge it into #9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants