[MU3] Fix some compiler warnings #6865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
changed the title
njvdberg
reviewed
Nov 15, 2020
| @@ -622,15 +622,15 @@ int InstrumentsWidget::findPrvItem(PartListItem* pli, int number) | |||
| const int last = number ? number - 1 : partiturList->topLevelItemCount(); | |||
| QTreeWidgetItem* item = nullptr; | |||
| for (int idx = 0; --number && (item = partiturList->topLevelItem(idx)); ++idx) { | |||
| PartListItem* pli = (PartListItem*)item; | |||
There was a problem hiding this comment.
What is the problem this rename is solving? Just curious.
There was a problem hiding this comment.
MSVC complains the variable name to be the same as the function's parameter
There was a problem hiding this comment.
MSVC doesn't like shadowing then. Something to keep in mind.
By the way, it might be solved also by the new PR I'm creating for ScoreOrdering (is related to it).
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.