-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3] Prepare for updated libsndfile #6489
Conversation
Attached the updated dependencies.zip (renamed to dependencies.7z.zip as GitHub doesn't allow .7x). Downloading it does report (in Microsoft Security Essentials/Windows Defender Antivirus) it to be infected with a virus/trojan (Trojan:Script/Wacatac.B!ml), not sure why though? Anyhow, further down I attached a newer version, so we can safely ignore this here. |
Do we really want it in 3.5.1, or even 3.6? I would merge this to master only (MU 4). |
Fine by me, but as long as dependencies.7z doesn't get updated, this PR doesn't make any difference |
And here the dependencies.7z for libsndfile 1.0.30 as taken from https://github.com/erikd/libsndfile/releases/tag/v1.0.30 Adding Opus support would probably not be wanted in 3.5.1, as it'd introduce new strings (for the export file selectors), even if that'd only be "Opus Audio" or "Ogg Opus Audio", which might not need to get translated at all. Still there is some value to be able to stay in sync with the latest libsndfile. |
It is in master now, waiting for it to get merged into 3.x for 3.6. Or a decision not to merge this into 3.x and rather close this PR |
@Jojo-Schmitz I'm not sure what this might affect for 3.x users, but one thing I know for sure, support for Opus should be in master, because it does not look like something trivial. So since this is already merged in master, I'd close this PR for 3.x |
Without the updated dependencies this PR does nothing, but allow for an updated libsndfile |
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
"Backport" of a single missing commit from musescore#6483, resp. including the never merged musescore#6489
This enables us to update libsndfile from the currently used 1.0.25 to 1.0.29 or later (1.0.30 is available meanwhile too, see https://github.com/erikd/libsndfile), which apparently changed the name of the lib from
libsndfile-1
to justsndfile
.In a separate step the dependencies file for Windows may get updated. If the newer one is found on build, that is taken, else the older one.
This in turn might enable us to add opus support, see https://musescore.org/en/node/288994