Skip to content

Fix #308771: migrate invisible staff lines and line color to staffType #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Aug 9, 2020

Resolves: https://musescore.org/en/node/308771
(Also resolves https://musescore.org/en/node/295722 )

Changes:
Migrated Invisible Staff Lines and Staff Color from Staff Properties to StaffType, and added these properties to the Staff Type Change inspector, which now allows to change staff visibility and color mid-staff.

image

Feedback is welcome.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@elerouxx elerouxx marked this pull request as draft August 9, 2020 03:37
@elerouxx elerouxx changed the title Fix #308771: migrate invisible staff lines and color to staffType [WIP] Fix #308771: migrate invisible staff lines and color to staffType Aug 9, 2020
@elerouxx elerouxx force-pushed the migrate-invisible-staff-lines-stype-3.x branch 2 times, most recently from aaefe51 to b89abe3 Compare August 10, 2020 02:30
@elerouxx elerouxx changed the title [WIP] Fix #308771: migrate invisible staff lines and color to staffType [WIP] Fix #308771: migrate invisible staff lines and line color to staffType Aug 10, 2020
@elerouxx elerouxx force-pushed the migrate-invisible-staff-lines-stype-3.x branch from b89abe3 to 06dbb53 Compare August 19, 2020 15:02
@elerouxx elerouxx changed the title [WIP] Fix #308771: migrate invisible staff lines and line color to staffType Fix #308771: migrate invisible staff lines and line color to staffType Aug 19, 2020
Fix #308771: migrate invisible staff lines and line color to staffType
@elerouxx elerouxx force-pushed the migrate-invisible-staff-lines-stype-3.x branch from 06dbb53 to 119c450 Compare November 14, 2020 16:07
@elerouxx elerouxx marked this pull request as ready for review November 14, 2020 16:37
@vpereverzev vpereverzev merged commit aefe389 into musescore:3.x Nov 16, 2020
@aspiers
Copy link

aspiers commented Nov 16, 2020

Awesome, thank you so much!

igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants