-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[MU3] fix #296528: Footers now appear inside page margins #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As mentioned also in the issue, this seems to effectively reverse the change made in #4944, although the implementation seems to be different. |
1727eaf
to
0be1582
Compare
0be1582
to
2868c3b
Compare
Adds one string to the translations. Not an issue, just noting... |
@dmitrio95 What do you think makes more sense? |
Well, I am not that sure what makes more sense. The change made by this PR makes both footers and headers lie outside of the margins area which is indeed more consistent than the situation we have now. In this regard I think this change makes sense. As this PR introduces a new style setting, |
I can't see any effect when toggling that option "Inside margins", it still stays outside the page margins? Seems 2.x has it outside the margins, (2.3.2 at least). 3.5.2 too (and I have no older 3.x handy to test), so no need to tweak the style files. |
I take it all back, I just accidentally left out one line of you PR, and of course (Murphy's Law) the vital one from textbase.cpp... Still no style default change needed for any prior version as far as I can tell. Or would this be needed only needed for 3.0? |
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
3.x is closed for any changes |
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue. Duplicate of musescore#5902
Resolves: https://musescore.org/en/node/296528
Added the ability to layout a textbase using the bottom margin (the old way used the top margin in every case). This change fixes the issue.