Repository navigation
Fix #35264: Deleting a tuplet selects the last bar of the score - #35273
Draft
davidstephengrant wants to merge 1 commit into
Draft
davidstephengrant wants to merge 1 commit into
davidstephengrant wants to merge 1 commit into
Conversation
cmdDeleteSelection() had no tick case for a tuplet, so the tick stayed -1 and findCR() selected the start of the last measure. Use the tuplet's tick, where cmdDeleteTuplet() puts the rest that replaces it. Assisted-by: Claude Code 2.1.290 (Claude Opus 5.5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #35264
Deleting a tuplet selected the start of the score's last bar.
cmdDeleteSelection()had no tick case for a tuplet, so the tick stayed -1 andfindCR()fell back to the last measure. It now uses the tuplet's tick, so the rest that replaces the tuplet is selected.Screen.Recording.2026-10-16.at.13.26.19.mov
Assisted by Claude Code 2.1.290 (Claude Opus 5.5)