Add ability to have an icon for dropdown#32554
Open
grliszas14 wants to merge 1 commit intomusescore:masterfrom
Open
Add ability to have an icon for dropdown#32554grliszas14 wants to merge 1 commit intomusescore:masterfrom
grliszas14 wants to merge 1 commit intomusescore:masterfrom
Conversation
Contributor
|
I am concerned that the dropdown may expand in the future and new properties will be added just because we already have icon property. The dropdown currently looks like a fairly simple component (just show the title), and if you look at the qt combobox component, it also does not have an icon. Let's explore the approach of customizing the content item for the dropdown, following the example of the content item in FlatButton. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: audacity/audacity#8576
Allow to set an icon for a dropdown item:


QA: