Open
Conversation
mike-spa
reviewed
Mar 5, 2026
| Ornament* ornament = c->findOrnament(); | ||
| if (ornament && ornament->showCueNote()) { | ||
| TLayout::layoutOrnamentCueNote(ornament, ctx); | ||
| } |
Contributor
There was a problem hiding this comment.
Could you explain why it needs additional layout in PageLayout and SystemLayout?
Contributor
Author
There was a problem hiding this comment.
The PageLayout call was for cross staff beam situations, but after removing it I can't find any issues.
We need the SystemLayout call because otherwise the only layout call is in MeasureLayout::computePreSpacingItems and it's never added to the skyline.
mike-spa
reviewed
Mar 5, 2026
| Ornament* ornament = c->findOrnament(); | ||
| if (ornament && ornament->showCueNote()) { | ||
| TLayout::layoutOrnamentCueNote(ornament, ctx); | ||
| } |
Contributor
There was a problem hiding this comment.
Could you explain why it needs additional layout in PageLayout and SystemLayout?
These should be calculated after articulations so we can avoid them
miiizen
force-pushed
the
fixCueNoteLayout
branch
from
4bac7ae to
1d4266b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: incorrect position of cue note on first layout