Skip to content

Set text style & properties position on migration from 4.6#32439

Open
miiizen wants to merge 4 commits intomusescore:4.7from
miiizen:47TextPosition
Open

Set text style & properties position on migration from 4.6#32439
miiizen wants to merge 4 commits intomusescore:4.7from
miiizen:47TextPosition

Conversation

@miiizen
Copy link
Contributor

@miiizen miiizen commented Mar 2, 2026

Resolves: #32395

Also fixes alignment reset buttons in properties.

@miiizen miiizen requested a review from mike-spa March 2, 2026 09:40
@miiizen miiizen linked an issue Mar 2, 2026 that may be closed by this pull request
4 tasks
@miiizen miiizen force-pushed the 47TextPosition branch 2 times, most recently from 1689ce0 to b7f734f Compare March 2, 2026 10:47
@davidstephengrant
Copy link
Contributor

@miiizen This is now working for defined text styles, but when text alignment is overridden (e.g. using the properties panel) the chosen alignment is not migrated correctly.

Example project file

@miiizen
Copy link
Contributor Author

miiizen commented Mar 4, 2026

Updated with this fix. I've also fixed the reset & set as default buttons. These were ignoring the new horizontal position buttons.

@miiizen miiizen changed the title Set text style position on migration from 4.6 Set text style & properties position on migration from 4.6 Mar 5, 2026
@miiizen miiizen added the vtests This PR produces approved changes to vtest results label Mar 5, 2026
@davidstephengrant
Copy link
Contributor

In general this seems to be working well, but there are a few individual text styles that are not fully migrated. See here, where Repeat text right has been set to center-aligned in 4.6.5. When opening the score with this PR the text is correctly centered within its bounding box, but the text box is still right-aligned to reference point.

There is some special handling for certain text styles which got the new position property in 4.6 (including repeat text, chord symbols, ...), but in this case there is still a visible difference in the score when opening and file made in an older version.

Screenshot from 2026-03-06 07-08-17

Text styles where I find there may still be an issue:

  • Bar number (alternate)
  • Repeat play count
  • Repeat text left
  • Repeat text right
  • Rehearsal mark
  • Chord symbol
  • Chord symbol (alternate)
  • Roman numeral analysis
  • Nashville number

@davidstephengrant
Copy link
Contributor

davidstephengrant commented Mar 6, 2026

After discussing with @miiizen we're happy with this for now. Tested and approved on Ubuntu 24.04.4 LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vtests This PR produces approved changes to vtest results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Defined Text Styles lose alignment settings in 4.7

2 participants