Open
Conversation
…turn the first one found"
Eism
approved these changes
Mar 2, 2026
Contributor
|
@krasko78 thank you! I agree with all points @DmitryArefiev can you please do general accessibility testing? There should be no regressions with the master. |
Contributor
Author
|
@DmitryArefiev Hey! Number 6 is related to the width of the main menu items File, Edit, View, etc. So we need to make sure that the main menu continues to look and feel the same. One specific thing that I tested out myself is that the main menu items should start to disappear from the right side if the window's width is shrunk so that the score title clashes with the menu items. Things like that (anything that occurs to you). Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32431
PR contains one commit per scenario:
1. When a navigation panel and its child navigation controls are created together as part of the creation of a control and its children, the
componentComplete()method ofAbstractNavigationcallscomponentComplete()on the associated accessible which then registers the accessible if not already registered. The problem is that thereg()method ofAccessibilityControlleralso registers the children of the accessibility without marking them as registered at this point. So whencomponentComplete()is called first for the navigation panel, this will register both its accessible as well as the child accessibles (seeNavigationControl::setPanel- callssetAccessibleParent()) and then whencomponentComplete()is called for any of the NavigationControl-s, they will attempt to register their already registered accessible-s without knowing they had been registered already.2. @mathesoncalum Do you think we need this warning? Why is it a problem if the version contains more than 3 parts? Let me know if you want to keep the warning and what other solution we should go with.
3., 4. and 5. Should be straight-forward.
6. @Eism This binding loop warning is back in AppMenuBar.qml where the
widthof the FlatButton is set. I think I fixed this some time ago and you and I talked about theTextMetrics. You mentioned that they were added to fix the shifting menu issue when the underlined letters appeared but that fix didn't work. So I assume we are OK with removing thewidthproperty and theTextMetrics?7. This warning happens for the "add-slur" action because now there is a slur button in the note input toolbar itself as well as a menu item for this under the Add toolbar button -> Lines -> Slur. I am changing the code to handle multiple items per action.
8. These warning happen when building MS without the VST module. Also results in a glitchy VST menu under menu Diagnostics.