Skip to content

[4.7] Fix Style dialog dropdown items too dark on Windows (light mode) #32000#32424

Open
pyonpyoco wants to merge 1 commit intomusescore:4.7from
pyonpyoco:fix/32000-style-dropdown-colors
Open

[4.7] Fix Style dialog dropdown items too dark on Windows (light mode) #32000#32424
pyonpyoco wants to merge 1 commit intomusescore:4.7from
pyonpyoco:fix/32000-style-dropdown-colors

Conversation

@pyonpyoco
Copy link
Contributor

@pyonpyoco pyonpyoco commented Feb 27, 2026

Resolves: #32000

ComboBoxDropdown.qml explicitly sets the ListItemBlank delegate’s normal background (normalColor: ui.theme.buttonColor), forcing items to be filled at all times.

This change removes that override so dropdown items use the default ListItemBlank styling (transparent idle background + theme-driven hover/pressed/selected states).

This keeps the change minimal and avoids broader dropdown/popup styling changes.
Tested on Windows 11 light mode (Chord Symbols / Measure Numbers / Repeats). Before/after screenshots attached.

スクリーンショット 2026-02-27 232709 スクリーンショット 2026-02-27 232721 スクリーンショット 2026-02-27 232732 スクリーンショット 2026-02-27 232826
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@zacjansheski
Copy link
Contributor

dropdown is very dark on my Windows device

Screenshot 2026-03-02 155046

@pyonpyoco
Copy link
Contributor Author

pyonpyoco commented Mar 3, 2026

I tested Windows 11 theme settings and found the behavior depends on “Default app mode”.

  • App mode Light: OK (matches the scope of this fix)
  • App mode Dark (including Custom: Windows Light / App Dark): the Style dialog dropdown popup becomes very dark / low-contrast.

This seems like a separate dark-mode styling issue (popup/menu layer using a different palette/theme).

(Japanese UI labels: Light = ライト, Dark = ダーク, Custom = カスタム, Default app mode = 既定のアプリ モード)

スクリーンショット 2026-03-04 000733 スクリーンショット 2026-03-04 000745 スクリーンショット 2026-03-04 000815 スクリーンショット 2026-03-04 000802

@pyonpyoco
Copy link
Contributor Author

In my previous test, I overlooked the MuseScore setting.
The previous results were based on Theme = Light.

Repro matrix (Windows 11): dropdown popup colors depend on both MuseScore “Appearance theme” and Windows “Default app mode”.

  • MuseScore Theme Light + Windows app mode Dark → popup becomes too dark.
  • MuseScore Theme Dark + Windows app mode Light → popup becomes too light.
  • Theme matches (Light+Light, Dark+Dark) → popup looks correct.
スクリーンショット 2026-03-04 011302 スクリーンショット 2026-03-04 011222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Style Dropdown menus colors a bit dark on Windows: Light Mode

3 participants