Fix ghost note playback [4.7]#32406
Merged
RomanPudashkin merged 1 commit intomusescore:4.7from Mar 3, 2026
Merged
Conversation
miiizen
force-pushed
the
32318-drumGhostNotes
branch
from
3b70ca5 to
b88cbba
Compare
| } | ||
|
|
||
| if ((bend->bendType() == GuitarBendType::PRE_BEND || bend->bendType() == GuitarBendType::PRE_DIVE) | ||
| && !startNote->bothParentheses()) { |
Contributor
There was a problem hiding this comment.
Can we remove bothParentheses() now?
src/engraving/dom/accidental.cpp
Outdated
| bool Accidental::parentNoteHasParentheses() const | ||
| { | ||
| return explicitParent() && parentItem()->isNote() ? toNote(parentItem())->bothParentheses() : false; | ||
| return explicitParent() && parentItem()->isNote() && toNote(parentItem())->parenInfo(); |
Contributor
There was a problem hiding this comment.
I don't like the name of this method... It's very easy to confuse it with the word "parent". Could you rename it to parenthesisInfo()?
Contributor
Author
There was a problem hiding this comment.
Yes, I have larger tidy/refactor chord parentheses open at the moment and would prefer to do it here
4 tasks
RomanPudashkin
approved these changes
Mar 2, 2026
miiizen
force-pushed
the
32318-drumGhostNotes
branch
from
0f108ab to
888d6f0
Compare
miiizen
changed the title
Contributor
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
miiizen
force-pushed
the
32318-drumGhostNotes
branch
from
888d6f0 to
a7aa0ba
Compare
RomanPudashkin
approved these changes
Mar 3, 2026
miiizen
pushed a commit
to miiizen/MuseScore
that referenced
this pull request
Mar 9, 2026
Fix ghost note playback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32318