Fix missing key signature after repeats#32368
Merged
miiizen merged 2 commits intomusescore:4.7from Mar 2, 2026
Merged
Conversation
4 tasks
Contributor
|
The all-naturals key signature change after the repeat barline is still going missing if there is a courtesy directly before the repeat. 4.6.5: 
This PR: 
|
miiizen
force-pushed
the
32177-ksAfterRepeat
branch
from
851c553 to
4964c3e
Compare
Contributor
Author
|
@davidstephengrant ready for another review! |
Contributor
|
@miiizen Tested and approved on Windows 11. |
This is a bit of an ugly solution, to be improved in future
& add tests
miiizen
force-pushed
the
32177-ksAfterRepeat
branch
from
4964c3e to
2a96281
Compare
mike-spa
approved these changes
Mar 2, 2026
miiizen
added a commit
to miiizen/MuseScore
that referenced
this pull request
Mar 3, 2026
Fix missing key signature after repeats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32177
This is a bit of an ugly solution, to be improved in future. Key signature layout now relies on the previous measure's
hasCourtesyKeySigflag. Currently, this flag is updated inMeasureLayout::removeSystemTrailer&MeasureLayout::setRepeatCourtesiesAndParens. We need to lay out the key signatures this will affect afterwards.