VTests: use correct reference ref #32081
Open
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem seems actually the opposite of what musescore@1a8ded4 tried to solve. Pull requests builds run on a merge commit of the PR branch and the base branch. That means that the latest changes on the base branch (at the time of pushing) will be considered, even if the PR branch is behind the base branch. Therefore, the reference should simply be the base branch, and not the merge-base (=common ancestor) of the PR branch and the base branch, because that would miss the latest changes from the base branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem seems actually the opposite of what 1a8ded4 tried to solve. Pull requests builds run on a merge commit of the PR branch and the base branch. That means that the latest changes on the base branch (at the time of pushing) will be considered, even if the PR branch is behind the base branch. Therefore, the reference should simply be the base branch, and not the merge-base (=common ancestor) of the PR branch and the base branch, because that would miss the latest changes from the base branch.