Fix #32068: String tunings drag & drop #32075
Conversation
cbjeukendrup
left a comment
cbjeukendrup
left a comment
There was a problem hiding this comment.
Seems fine to me, one question:
src/engraving/dom/measure.cpp
Outdated
| return nullptr; | ||
| } | ||
| staffIdx = staff->idx(); | ||
| e->setParent(first()); |
There was a problem hiding this comment.
We might want to ensure that it is a "chord rest or time tick" segment and not a random key signature header segment etc
There was a problem hiding this comment.
Should we consider 'reparenting' these elements to measures instead, since that's what they can be added to? Last I checked, regardless of which segment they are anchored to, they are laid out at the start of the measure (so anchoring should be disabled accordingly, too).
There was a problem hiding this comment.
ensure that it is a "chord rest or time tick segment"...
Updated now @cbjeukendrup
There was a problem hiding this comment.
It's a good point @XiaoMigros - definitely worth considering. We'll need to discuss a couple of design points before going ahead with that though, so for the purposes of 4.7 we'll push ahead with the current version of string tunings. Thanks!
|
Yes, looks good. I believe I only tested copy/paste thoroughly, hence the oversight. Thanks for catching this! |
mathesoncalum
force-pushed
the
32068-string_tuning_drop
branch
from
2b8f753 to
9873e97
Compare
3 participants
Resolves: #32068
String tunings are handled by
prepareDropMeasureAnchorElementinNotationInteraction. Removing the logic fromMeasure::acceptDropin 427f6d6 means that we never set a target measure for the drop. The changes in this PR revert to what we had before this commit (with a couple tweaks).Curious to hear your thoughts too @XiaoMigros if you get a chance - copy/pasting string tunings still appears to work as expected after these changes.