Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

Resolves: #32070

Note: design will only ever add a single note per chord to range selections. This differs from list selections, where multiple notes could be added.

@XiaoMigros XiaoMigros force-pushed the selection-filter-interval branch from 4d1cc6b to 6bcf666 Compare February 6, 2026 20:23
@XiaoMigros XiaoMigros force-pushed the selection-filter-interval branch 3 times, most recently from c89cc60 to 7c959e3 Compare February 6, 2026 21:05
@XiaoMigros XiaoMigros force-pushed the selection-filter-interval branch from 7c959e3 to c2240f2 Compare February 6, 2026 22:48
@XiaoMigros XiaoMigros force-pushed the selection-filter-interval branch from c2240f2 to 0e2c9d4 Compare February 7, 2026 00:02
@cbjeukendrup cbjeukendrup requested review from zacjansheski and removed request for zacjansheski February 7, 2026 03:19
@avvvvve
Copy link

avvvvve commented Feb 9, 2026

@XiaoMigros Approved!


Also, noting this because it seemed like a bug for a second, but then I realized it's because the selection filter is still active.

I expected the newly-added notes to be selected after running the 'add interval' operation (as happens when you start with a list selection), but since the selection filter is in effect, the bottom note stays selected and the top note gets selected (because the a new note was added to the chord, and now the 'Top note' filter is on because it wasn't showing before).

Screen.Recording.2026-02-09.at.11.29.57.AM.mov

For me, this just gets at something that always has felt a bit clunky about the selection filter to me: when you make a new selection, the selection filter is still in effect. When we have time I think it would still be nice to create a version of the selction filter that lets you press a button to "filter" the selection based on your filtering options. @bkunda @jessjwilliamson pinning the thought for another time!

@avvvvve avvvvve self-requested a review February 9, 2026 19:11
@MarcSabatella
Copy link
Contributor

FWIW, this has been a long-standing complaint against the selection filter. It's especially problematic if you use the filter to exclude voice 1 from a selection, because now you can't select anything anymore unless it happens to have content in other voices. So for example, trying to copy & paste voice 2 from one place to another fails at first because you can't select the destination until you remember to re-enable voice 1.

A design that handled all of this better would be welcome indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding interval seems overseen in selection filter

5 participants