Replace straight quotes with curly quotes (#17550) #31460
Merged
+95
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
approved these changes
Dec 16, 2025
cbjeukendrup
approved these changes
Dec 17, 2025
Member
cbjeukendrup
left a comment
cbjeukendrup
left a comment
There was a problem hiding this comment.
I believe this is fine, undo-stack-wise, and on a quick test I didn't see any suspicious behaviour or warnings.
Contributor
|
This does not consider non-English quote styles (see the issue for examples), does it? |
Contributor
|
If I make a curly bracket straight, then highlight+delete, then undo, the " is a & Untitled.mp4 |
Contributor
|
Actually that bug is in master as well, so it is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17550
In this PR, straight quotes are automatically replaced with curly quotes. The replacement is performed as a separate undo action, so pressing
Ctrl+Zrestores the original straight quote.Code-wise:
NotationInteraction::doEditTextmethod which will detect straight quotes and perform the undoable replacement.NotationInteraction::editElement(QKeyEvent*)by moving key handling intohandleKeyPress.