Skip to content

Conversation

@pyonpyoco
Copy link

@pyonpyoco pyonpyoco commented Dec 11, 2025

Resolves: #23755

Description:
This PR adds support for entering T/t (thumb) and P/p (pulgar) as fingering values for fretboard diagrams.

Changes:

  • Updated DOM fingering parsing and internal values.
  • Mapped T/t → 6, P/p → 7 internally to keep the existing data structure.
  • Updated Inspector UI to allow entering T and P.
  • Updated reading/writing logic to support these values.

Backward compatibility:
Opening scores using this feature in older versions (4.6.3) of MuseScore currently displays the digits 6 and 7.
Please advise if backward compatibility handling or a conversion layer is preferred.

UI example

スクリーンショット 2025-12-11 210040 スクリーンショット 2025-12-11 214911
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pyonpyoco pyonpyoco force-pushed the feature/fret-tp-fingering branch from ba87f29 to 025ee51 Compare December 12, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fretboard diagram properties: Accept T, t, P, and p as valid fingerings

1 participant