Implement chord brackets #31419
Open
Implement chord brackets #31419
+1,086
−276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
reviewed
Dec 17, 2025
Contributor
miiizen
left a comment
miiizen
left a comment
There was a problem hiding this comment.
Lovely stuff, very neat!
| default: | ||
| LOGE() << "Not handled: " << item->typeName(); | ||
| IF_ASSERT_FAILED(false) { | ||
| /*IF_ASSERT_FAILED(false) { |
Contributor
There was a problem hiding this comment.
Should we keep some sort of assert here?
Contributor
Author
There was a problem hiding this comment.
Oops that was committed by mistake, good catch
| const double y1 = ldata->bbox().top() + halfLineWidth; | ||
| const double y2 = ldata->bbox().bottom() - halfLineWidth; | ||
|
|
||
| double w = item->hookLength().toMM(item->spatium()); |
Contributor
There was a problem hiding this comment.
Wherever we want a spatium value to scale with staff size, we should use absoluteFromSpatium. eg. item->absoluteFromSpatium(item->hookLength()).
(All uses of toMM are due an audit anyway)
Contributor
Author
There was a problem hiding this comment.
Excellent point, thanks
mike-spa
force-pushed
the
arpeggioBracketImprovements
branch
from
eb52c43 to
014933b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17368