Transpose fret diagrams #31113
Open
Transpose fret diagrams #31113
+5,121
−3,187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
23712-transposeFretDiagrams
branch
3 times, most recently
from
228bb74 to
c0ffc20
Compare
avvvvve
approved these changes
Nov 24, 2025
Contributor
|
Tested on Win10 - PASS |
As far as I can tell, this information hasn't been used in files saved after 4.0. There's no reason to be reading and writing it alongside data we do use
miiizen
force-pushed
the
23712-transposeFretDiagrams
branch
from
a336e63 to
f797a35
Compare
This data is read into an `unordered_map` which does not allow duplicates. Only the first entries should have been used. However, I found some discrepancies between macOS and Linux. For an Ab chord, macOS was using the first entry as expected. Linux was using the second. I have a feeling this is due to a faulty `hash` implementation for `String`. It seemed like on Linux the collision wasn't noticed in `insert` and the original entry overwritten. I couldn't get this working and removing redundant entries seemed a sensible thing to do anyway.
miiizen
force-pushed
the
23712-transposeFretDiagrams
branch
from
f797a35 to
384c638
Compare
This was causing overflows somewhere and causing `transposeTpc` to return different values on macOS and Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23712