fix position of repeatDot in Emmentaler #28157
Open
+6,024
−2,343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TTF version looks slightly thicker than the OTF version. |
its-not-nice
approved these changes
May 28, 2025
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 28, 2025
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 28, 2025
|
@rettinghaus please check the last commit if my backport Jojo-Schmitz#948, dealing with Emmentaler as an external font, I guess @worldwideweary and @mirabilos would appreciate... |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 28, 2025
|
@Jojo-Schmitz I'm not so sure about this, because you could generate a newer ttf file from the source, so you'd never know which version is the "correct" one. |
|
True, but if not this would maintain compatibility with the existing old font |
rettinghaus
force-pushed
the
fix/emmentaler
branch
from
eec3282 to
69c1244
Compare
|
Just rebased to resolve merge conflict or really changed something? |
|
just a rebase |
|
I reported the error in Ekmelos, so maybe we can get rid of this workaround completely at some point … 🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #28155
Brings not only a fix of the dot position but also a switch to open type. Regenerated the metadata.json file.