Skip to content

Add a "selection mode" tool to the toolbar. #28115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kbloom
Copy link
Contributor

@kbloom kbloom commented May 22, 2025

Resolves: #27513

It feels weird to switch back to selection mode by going to the toolbar and clicking on a note input mode to disable it. Adding a "Selection Mode" button that switches to selection mode makes the UI of these buttons more similar to how tool buttons behave in other applications (for example most graphics programs).

Some unfinished bits that I need help with:

  • It would be nice if the Select button would remain highlighted once clicked, similar to how the note input buttons do. I wasn't sure how to do that.
  • It feels weird to add an icon by editing a binary font file in FontForge, instead of creating a separate, reviewable file (such as an SVG) for the icon. (And what happen if my addition conflicted with someone else's changes to the font file.) Did I do that right?
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@bkunda
Copy link

bkunda commented May 28, 2025

As I mentioned in my comment here, we do not plan to add any additional modes to differentiate selection vs. note input functionalities at this time.

We also will not be introducing new functionality with the intention of later replacing it (as was suggested in this comment). This just creates technical and design debt that we have to deal with later on. It also establishes new user expectations that then have to be changed.

There are plenty of other available projects (see here), so if you're interested in contributing then please look there first and discuss your intention with the internal team before submitting a PR.

@bkunda bkunda closed this May 28, 2025
@kbloom
Copy link
Contributor Author

kbloom commented May 28, 2025 via email

@kbloom
Copy link
Contributor Author

kbloom commented May 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Select mode" button on toolbar.
2 participants