Skip to content

Don't load project twice when converting parts #28100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cbjeukendrup
Copy link
Member

and fix a bug where the ret of convertScorePartsToPdf etc. was ignored

and fix a bug where the ret of `convertScorePartsToPdf` etc. was ignored
@cbjeukendrup cbjeukendrup requested a review from Eism May 20, 2025 20:44
@RomanPudashkin RomanPudashkin removed the request for review from Eism May 26, 2025 08:50
@cbjeukendrup
Copy link
Member Author

@DmitryArefiev Please check if there are no regressions with --export-score-parts command line option

@DmitryArefiev
Copy link
Contributor

@DmitryArefiev Please check if there are no regressions with --export-score-parts command line option

@cbjeukendrup Should be checked on all OSs?

@cbjeukendrup
Copy link
Member Author

One should be enough :)

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented May 28, 2025

@cbjeukendrup From https://musescore.org/en/handbook/3/command-line-options I see:

-P | --export-score-parts

When converting to PDF with the -o option, append each part’s pages to the created PDF file. If the score has no parts, all default parts will temporarily be generated automatically.

Can you help with syntax please?

I know how it works with -o command when converting to pdf (on Windows):

musescore.exe -o [filename].pdf [filename].mscz

but didn't find how to add -P command

@DmitryArefiev
Copy link
Contributor

@cbjeukendrup OK. I've found the way:

MuseScore.exe --export-score-parts 1.mscz -o 1.pdf

(-P doesn't work with MuseScore4)

@DmitryArefiev Please check if there are no regressions with --export-score-parts command line option

There is no regressions with master. But --export-score-parts + -o commands don't work properly with 4.6 master as it work with MuseScore3. Is it expected?

@cbjeukendrup
Copy link
Member Author

I wasn't fully aware it was broken, but it seems there is indeed an open issue about it: #22887
Anyway, I'll merge this PR, because it fixes a little bit of tech debt, and then we can fix that issue later, depending on how it is prioritised.

@cbjeukendrup cbjeukendrup merged commit 1dccd0a into musescore:master May 28, 2025
12 checks passed
@cbjeukendrup cbjeukendrup deleted the scoreparts_converter_improvements branch May 28, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants