vtest config for small screens #28096
Conversation
mikekirin
force-pushed
the
small-screens-vtest
branch
from
aa36afd to
350cde0
Compare
| @@ -42,6 +42,10 @@ echo ======================= | |||
|
|
|||
| echo Generate reference pngs: | |||
| ./vtest/vtest-generate-pngs.sh -o ./reference_pngs -m $REF_BIN | |||
| ./vtest/vtest-generate-pngs.sh -o ./reference_pngs_small -m $REF_BIN -s ./vtest/scores_small -d 460 -S ./vtest/small.mss | |||
| #./vtest/vtest-generate-pngs.sh -o ./reference_pngs_gp_small -m $REF_BIN -s ./vtest/gp_small -d 460 -S ./vtest/small.mss --gp-linked | |||
There was a problem hiding this comment.
This one commented out because master branch can't read gp files now. I'll make another PR with these uncommented after this PR will be merged.
| ./vtest/vtest-compare-pngs.sh --ci 1 -c ./current_pngs_small -r ./reference_pngs_small | ||
| # - name: Compare PNGs gp | ||
| # run: | | ||
| # ./vtest/vtest-compare-pngs.sh --ci 1 -c ./current_pngs_gp_small -r ./reference_pngs_gp_small |
There was a problem hiding this comment.
This one commented out because master branch can't read gp files now. I'll make another PR with these uncommented after this PR will be merged.
CMakeLists.txt
Outdated
| @@ -69,6 +69,7 @@ option(MUE_BUILD_ENGRAVING_TESTS "Build engraving tests" ON) | |||
| option(MUE_BUILD_ENGRAVING_DEVTOOLS "Build engraving devtools" ON) | |||
| option(MUE_BUILD_ENGRAVING_PLAYBACK "Build engraving playback" ON) | |||
| option(MUE_BUILD_IMPORTEXPORT_MODULE "Build importexport module" ON) | |||
| option(MUE_BUILD_GP_MODULE "Build guitar pro module without import export module" OFF) | |||
There was a problem hiding this comment.
It's confusing that the module is "disabled" but enabled :)
We need to think about how to do it better.
I see varians:
- Make it so that the gp module is regulated only by the MUE_BUILD_GP_MODULE option (MUE_BUILD_IMPORTEXPORT_MODULE does not affect it)
- In the future, remove the MUE_BUILD_IMPORTEXPORT_MODULE option completely, make separate options.
- Make these options not boolean, but string, so that there are three states: default, on, off
There was a problem hiding this comment.
I'd go with the second variant. It will be very verbose though. From the other hand this verbosity would be much clear for the reader of the script than the string options which will be harder to setup imho.
Also I'd skip the first variant since updating the usage for all 12 modules won't take too much time.
Do you agree?
mikekirin
force-pushed
the
small-screens-vtest
branch
from
350cde0 to
5f9e8b5
Compare
SetupConfigure.cmake
Outdated
| NOT MUE_BUILD_IMPEXP_GUITARPRO_MODULE AND | ||
| NOT MUE_BUILD_IMPEXP_MEI_MODULE) | ||
|
|
||
| set(MUE_BUILD_IMPEXP_VIDEOEXPORT_MODULE OFF) | ||
| endif() |
There was a problem hiding this comment.
this block is not needed
mikekirin
force-pushed
the
small-screens-vtest
branch
from
5f9e8b5 to
d9dabdb
Compare
Vtest config for small screens