Fix grace note after stem slash save #28081
Open
+230
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-not-nice
approved these changes
May 19, 2025
mike-spa
reviewed
May 23, 2025
| @@ -910,7 +910,7 @@ void TWrite::write(const Chord* item, XmlWriter& xml, WriteContext& ctx) | |||
| if (item->hook() && item->hook()->isUserModified()) { | |||
| write(item->hook(), xml, ctx); | |||
| } | |||
| if (item->showStemSlash() && item->isUserModified()) { | |||
| if (item->showStemSlash() && item->showStemSlash() != item->propertyDefault(Pid::SHOW_STEM_SLASH).toBool()) { | |||
There was a problem hiding this comment.
As part of #28118 I've found myself doing kind of the opposite of this, i.e. override/specialize isUserModified as necessary to include this kind of information. In principle, I'd find it preferable for the read/write modules to know as little as possible about the inside working of each EngravingItem, so I think this kind of information would be better hidden inside the isUserModified method. But it's just a thing of principle so feel free to also do this in a next PR
mike-spa
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #27944